mbutrovich commented on code in PR #16996:
URL: https://github.com/apache/datafusion/pull/16996#discussion_r2267606728
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -307,29 +318,9 @@ impl NestedLoopJoinExec {
))
}
- /// Returns a vector indicating whether the left and right inputs maintain
their order.
- /// The first element corresponds to the left input, and the second to the
right.
- ///
- /// The left (build-side) input's order may change, but the right
(probe-side) input's
- /// order is maintained for INNER, RIGHT, RIGHT ANTI, and RIGHT SEMI joins.
- ///
- /// Maintaining the right input's order helps optimize the nodes down the
pipeline
- /// (See [`ExecutionPlan::maintains_input_order`]).
- ///
- /// This is a separate method because it is also called when computing
properties, before
- /// a [`NestedLoopJoinExec`] is created. It also takes [`JoinType`] as an
argument, as
- /// opposed to `Self`, for the same reason.
- fn maintains_input_order(join_type: JoinType) -> Vec<bool> {
- vec![
- false,
- matches!(
- join_type,
- JoinType::Inner
- | JoinType::Right
- | JoinType::RightAnti
- | JoinType::RightSemi
- ),
- ]
+ /// This join implementation does not preserve the input order of either
side.
Review Comment:
Not part of your diff, but spotted while reviewing, line 183:
```
/// the hash table creation.
inner_table: OnceAsync<JoinLeftData>,
```
The hash table comment seems like an old copy-paste error from hash_join.rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
