Omega359 commented on PR #10: URL: https://github.com/apache/datafusion-testing/pull/10#issuecomment-3177274067
I went through the first commit completely and most of the second commit. The first commit is fine, my main concern is really not with the changes in the 2nd commit but I guess the original PR which seems to allow queries that I would really have expected to fail (avg(distinct), divide by zero). Assuming that is ok than the changes here are solid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
