zhuqi-lucas commented on PR #17136:
URL: https://github.com/apache/datafusion/pull/17136#issuecomment-3178888608

   > ๐Ÿค–: Benchmark completed
   > 
   > Details
   > 
   > ```
   > Comparing HEAD and test_non_exact_size_batch
   > --------------------
   > Benchmark tpch_mem_sf1.json
   > --------------------
   > โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   > โ”ƒ Query        โ”ƒ      HEAD โ”ƒ test_non_exact_size_batch โ”ƒ       Change โ”ƒ
   > โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   > โ”‚ QQuery 1     โ”‚  96.18 ms โ”‚                  93.30 ms โ”‚    no change โ”‚
   > โ”‚ QQuery 2     โ”‚  20.96 ms โ”‚                  22.99 ms โ”‚ 1.10x slower โ”‚
   > โ”‚ QQuery 3     โ”‚  32.14 ms โ”‚                  36.01 ms โ”‚ 1.12x slower โ”‚
   > โ”‚ QQuery 4     โ”‚  18.39 ms โ”‚                  18.60 ms โ”‚    no change โ”‚
   > โ”‚ QQuery 5     โ”‚  48.92 ms โ”‚                  55.22 ms โ”‚ 1.13x slower โ”‚
   > โ”‚ QQuery 6     โ”‚  11.99 ms โ”‚                  11.63 ms โ”‚    no change โ”‚
   > โ”‚ QQuery 7     โ”‚  81.98 ms โ”‚                  93.94 ms โ”‚ 1.15x slower โ”‚
   > โ”‚ QQuery 8     โ”‚  24.78 ms โ”‚                  25.59 ms โ”‚    no change โ”‚
   > โ”‚ QQuery 9     โ”‚  53.99 ms โ”‚                  54.99 ms โ”‚    no change โ”‚
   > โ”‚ QQuery 10    โ”‚  40.09 ms โ”‚                  49.73 ms โ”‚ 1.24x slower โ”‚
   > โ”‚ QQuery 11    โ”‚  11.19 ms โ”‚                  12.19 ms โ”‚ 1.09x slower โ”‚
   > โ”‚ QQuery 12    โ”‚  30.34 ms โ”‚                  34.79 ms โ”‚ 1.15x slower โ”‚
   > โ”‚ QQuery 13    โ”‚  25.57 ms โ”‚                  27.45 ms โ”‚ 1.07x slower โ”‚
   > โ”‚ QQuery 14    โ”‚   9.60 ms โ”‚                  12.17 ms โ”‚ 1.27x slower โ”‚
   > โ”‚ QQuery 15    โ”‚  18.88 ms โ”‚                  23.25 ms โ”‚ 1.23x slower โ”‚
   > โ”‚ QQuery 16    โ”‚  17.43 ms โ”‚                  21.64 ms โ”‚ 1.24x slower โ”‚
   > โ”‚ QQuery 17    โ”‚  94.13 ms โ”‚                 115.21 ms โ”‚ 1.22x slower โ”‚
   > โ”‚ QQuery 18    โ”‚ 189.20 ms โ”‚                 236.46 ms โ”‚ 1.25x slower โ”‚
   > โ”‚ QQuery 19    โ”‚  25.37 ms โ”‚                  31.06 ms โ”‚ 1.22x slower โ”‚
   > โ”‚ QQuery 20    โ”‚  31.24 ms โ”‚                  37.38 ms โ”‚ 1.20x slower โ”‚
   > โ”‚ QQuery 21    โ”‚ 141.50 ms โ”‚                 174.59 ms โ”‚ 1.23x slower โ”‚
   > โ”‚ QQuery 22    โ”‚  13.79 ms โ”‚                  15.71 ms โ”‚ 1.14x slower โ”‚
   > โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   > โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   > โ”ƒ Benchmark Summary                        โ”ƒ           โ”ƒ
   > โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   > โ”‚ Total Time (HEAD)                        โ”‚ 1037.67ms โ”‚
   > โ”‚ Total Time (test_non_exact_size_batch)   โ”‚ 1203.91ms โ”‚
   > โ”‚ Average Time (HEAD)                      โ”‚   47.17ms โ”‚
   > โ”‚ Average Time (test_non_exact_size_batch) โ”‚   54.72ms โ”‚
   > โ”‚ Queries Faster                           โ”‚         0 โ”‚
   > โ”‚ Queries Slower                           โ”‚        17 โ”‚
   > โ”‚ Queries with No Change                   โ”‚         5 โ”‚
   > โ”‚ Queries with Failure                     โ”‚         0 โ”‚
   > โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   > ```
   
   Thank you @alamb for benchmark, it's worse than the exact batch, it may due 
to the extra allocation because we reserve for fixed batch_size.
   
   I need to investigate it more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to