alamb commented on PR #99: URL: https://github.com/apache/datafusion-site/pull/99#issuecomment-3179323682
@JigaoLuo > Nice blog @alamb. Thanks for having me here! I’ve done my first pass, and I think the topic is great. I’ve left a few comments in the review. ❤️ thank you for taking the time to provide feedback > One note on the structure, and it might be worth discussing here as well: > > * I found the titles of the subtopics we’re covering to be quite clear, but the number of top-level sections (# in Markdown) seems to exceed the actual number of distinct subtopics. @nuno-faria mentioned this too and I have demoted all sections one level. Hopefully that is clearer. > * That’s also why I think the “Apache Parquet Overview” section felt a bit out of place—it appears suddenly in the middle of the blog. > * I definitely think including background on Parquet is important. What I meant was that we could consolidate all the Parquet-related background content into a single top-level section, rather than having it scattered throughout. > * It’s possible I misunderstood the intended structure, so feel free to clarify if that’s the case. In my mind there is a balance between: 1. Showing / demonstrating how to use external indexes for Parquet using DataFusion 2. Explaining the general concept of external indexes / heirarchal pruning I believe the post will be more widely read if it is about more than just Parquet and Datafusion, and that by having the background content it will be easier for people to even realize this is a technique that they can use. So I guess I would say the structure is deliberate, but I can see how it may not be obvious Let me know if that makes sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
