alamb opened a new pull request, #17154:
URL: https://github.com/apache/datafusion/pull/17154

   ## Which issue does this PR close?
   
   - Related to https://github.com/apache/datafusion/issues/17122
   
   
   ## Rationale for this change
   
   @hareshkh [tracked 
down](https://github.com/apache/datafusion/issues/17122#issuecomment-3178108708)
 a performance issue in the stats projection code where we were silently 
ignoring errors when evaluating the stats projection. This both 
   
   1. silently masked a real bug as well
   2. caused a performance issue (each DataFusion error allocates a String)
   
   Let's not ignore errors silently, but instead return them to the caller.
   
   ## What changes are included in this PR?
   
   1. Return errors rather than ignoring them
   
   ## Are these changes tested?
   
   Yes, by existing CI tests
   
   ## Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to