findepi commented on code in PR #17139: URL: https://github.com/apache/datafusion/pull/17139#discussion_r2270985767
########## datafusion/sqllogictest/test_files/issue_17138.slt: ########## @@ -0,0 +1,36 @@ +statement ok Review Comment: This showed up as a regression so i named this file as a regression test. We have regression tests stucked in other files, but this creates risk of inadvertently changing the scenario and so thus breaking the regression properties of a test. They are better of isolated. Would it help if this file is moved under a directory for just regression cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
