ding-young commented on code in PR #17147:
URL: https://github.com/apache/datafusion/pull/17147#discussion_r2271887118
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -430,6 +430,9 @@ pub(crate) struct GroupedHashAggregateStream {
/// Execution metrics
baseline_metrics: BaselineMetrics,
+
+ /// Metrics for sorting in the spill manager
+ lexsort_metrics: LexSortMetrics,
Review Comment:
The current comment is fine, but perhaps we could clarify that this only
applies to `sort_batch`, not `SortPreservingMerge` via `StreamingMergeBuilder`,
since "sorting in the spill manager" could imply both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
