andygrove commented on code in PR #2141:
URL: https://github.com/apache/datafusion-comet/pull/2141#discussion_r2274142811
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -1848,16 +1848,16 @@ class ParquetReadV1Suite extends ParquetReadSuite with
AdaptiveSparkPlanHelper {
test("Test V1 parquet scan uses respective scanner") {
Seq(
("false", CometConf.SCAN_NATIVE_COMET, "FileScan parquet"),
- ("true", CometConf.SCAN_NATIVE_COMET, "CometScan parquet"),
+ ("true", CometConf.SCAN_NATIVE_COMET, "CometScan [native_comet]
parquet"),
("true", CometConf.SCAN_NATIVE_DATAFUSION, "CometNativeScan"),
- ("true", CometConf.SCAN_NATIVE_ICEBERG_COMPAT, "CometScan
parquet")).foreach {
- case (cometEnabled, cometNativeScanImpl, expectedScanner) =>
+ ("true", CometConf.SCAN_NATIVE_ICEBERG_COMPAT, "CometScan
[native_iceberg_compat] parquet"))
Review Comment:
This test needed an update (and seems more useful now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
