Re: [PR] Normalize `NUL` to `\0` in sqllogictests [datafusion]

[via GitHub]

Jefffrey commented on PR #17181:
URL: https://github.com/apache/datafusion/pull/17181#issuecomment-3185721475

   > It is strange that Github still renders this as binary for me
   > <img alt="Screenshot 2025-08-13 at 4 38 07 PM" width="699" height="263" 
src="https://private-user-images.githubusercontent.com/490673/477738132-0a5a8058-6c22-454f-89cb-7b33ddaf7b43.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTUxMTgxMjUsIm5iZiI6MTc1NTExNzgyNSwicGF0aCI6Ii80OTA2NzMvNDc3NzM4MTMyLTBhNWE4MDU4LTZjMjItNDU0Zi04OWNiLTdiMzNkZGFmN2I0My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwODEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDgxM1QyMDQzNDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03M2FhZTlmNTA2ZGM2YWMzNTgwY2RmNjZhZmE0OWU5Y2Y0MDNhNGI5NmI1Y2NiZmQ0ZjZkMzYyMzYwMmQxOGQyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.YGGXYBXzfBo1h5ucHpj3sB7ZP6BpNPquk9rXDXXeDZ0";>
   > 
   > 🤷
   > 
   > Looks like git still treats them as binary too 🤔
   > 
   > ```shell
   > diff --git a/datafusion/sqllogictest/src/engines/conversion.rs 
b/datafusion/sqllogictest/src/engines/conversion.rs
   > index 92ab64059..de3acbee9 100644
   > --- a/datafusion/sqllogictest/src/engines/conversion.rs
   > +++ b/datafusion/sqllogictest/src/engines/conversion.rs
   > @@ -35,7 +35,8 @@ pub(crate) fn varchar_to_str(value: &str) -> String {
   >      if value.is_empty() {
   >          "(empty)".to_string()
   >      } else {
   > -        value.trim_end_matches('\n').to_string()
   > +        // Escape nulls so that github renders them correctly in the webui
   > +        value.trim_end_matches('\n').replace("\u{0000}", "\\0")
   >      }
   >  }
   > 
   > diff --git a/datafusion/sqllogictest/test_files/expr.slt 
b/datafusion/sqllogictest/test_files/expr.slt
   > index f0bf5d76e..eeea3cd39 100644
   > Binary files a/datafusion/sqllogictest/test_files/expr.slt and 
b/datafusion/sqllogictest/test_files/expr.slt differ
   > diff --git a/datafusion/sqllogictest/test_files/spark/string/char.slt 
b/datafusion/sqllogictest/test_files/spark/string/char.slt
   > index abf0c7076..299e2a041 100644
   > Binary files a/datafusion/sqllogictest/test_files/spark/string/char.slt 
and b/datafusion/sqllogictest/test_files/spark/string/char.slt differ
   > ```
   
   I think only for this diff, since it still has the NUL character. If I check 
the file after the change, its back to text:
   
   
https://github.com/apache/datafusion/blob/dd224c4a6db4d6e2e68f74160c7577a3b122983f/datafusion/sqllogictest/test_files/expr.slt


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org