kazuyukitanimura commented on code in PR #2143:
URL: https://github.com/apache/datafusion-comet/pull/2143#discussion_r2274887676
##########
docs/source/user-guide/expressions.md:
##########
@@ -44,6 +44,15 @@ The following Spark expressions are currently available. Any
known compatibility
| IntegralDivide (`div`) | All operands are cast to DecimalType (in case the
input type is not already decima type) with precision 19 and scale 0. Please
set `spark.comet.cast.allowIncompatible` to `true` to enable DataFusion’s cast
operation for LongType inputs. |
| Remainder (`%`) |
|
+## Binary Try Arithmetic
+
+| Expression | Notes
|
+|------------|----------------------------------------------------------------------------|
+| `try_add` | Adds operands (IntegerTypes only) or results NULL incase of
overflow |
+| `try_sub` | Subtracts operands (IntegerTypes only) or results NULL incase
of overflow |
+| `try_mul` | Multiplies operands (IntegerTypes only) or results NULL incase
of overflow |
+| `try_div` | Subtracts operands (IntegerTypes only) or results NULL incase
of overflow |
Review Comment:
If it falls back to Spark, then it's fine, but I was unable to find the code
that checks the data type. I wonder what will happen with
float/double/decimal...etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
