zhuqi-lucas commented on PR #17105:
URL: https://github.com/apache/datafusion/pull/17105#issuecomment-3188036331

   > ๐Ÿค–: Benchmark completed
   > 
   > Details
   > 
   > ```
   > Comparing HEAD and revive_to_use_upstream_arrow_coalesce
   > --------------------
   > Benchmark tpch_mem_sf1.json
   > --------------------
   > 
โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   > โ”ƒ Query        โ”ƒ      HEAD โ”ƒ revive_to_use_upstream_arrow_coalesce โ”ƒ       
 Change โ”ƒ
   > 
โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   > โ”‚ QQuery 1     โ”‚  97.06 ms โ”‚                              83.14 ms โ”‚ 
+1.17x faster โ”‚
   > โ”‚ QQuery 2     โ”‚  20.75 ms โ”‚                              23.00 ms โ”‚  
1.11x slower โ”‚
   > โ”‚ QQuery 3     โ”‚  32.13 ms โ”‚                              35.53 ms โ”‚  
1.11x slower โ”‚
   > โ”‚ QQuery 4     โ”‚  18.36 ms โ”‚                              19.71 ms โ”‚  
1.07x slower โ”‚
   > โ”‚ QQuery 5     โ”‚  49.02 ms โ”‚                              55.08 ms โ”‚  
1.12x slower โ”‚
   > โ”‚ QQuery 6     โ”‚  11.81 ms โ”‚                              11.65 ms โ”‚     
no change โ”‚
   > โ”‚ QQuery 7     โ”‚  89.03 ms โ”‚                              94.83 ms โ”‚  
1.07x slower โ”‚
   > โ”‚ QQuery 8     โ”‚  23.60 ms โ”‚                              25.81 ms โ”‚  
1.09x slower โ”‚
   > โ”‚ QQuery 9     โ”‚  52.99 ms โ”‚                              56.22 ms โ”‚  
1.06x slower โ”‚
   > โ”‚ QQuery 10    โ”‚  40.33 ms โ”‚                              41.90 ms โ”‚     
no change โ”‚
   > โ”‚ QQuery 11    โ”‚  11.12 ms โ”‚                              11.81 ms โ”‚  
1.06x slower โ”‚
   > โ”‚ QQuery 12    โ”‚  30.00 ms โ”‚                              30.29 ms โ”‚     
no change โ”‚
   > โ”‚ QQuery 13    โ”‚  25.83 ms โ”‚                              25.76 ms โ”‚     
no change โ”‚
   > โ”‚ QQuery 14    โ”‚   9.92 ms โ”‚                              10.32 ms โ”‚     
no change โ”‚
   > โ”‚ QQuery 15    โ”‚  18.48 ms โ”‚                              19.27 ms โ”‚     
no change โ”‚
   > โ”‚ QQuery 16    โ”‚  17.50 ms โ”‚                              17.95 ms โ”‚     
no change โ”‚
   > โ”‚ QQuery 17    โ”‚  97.90 ms โ”‚                              99.31 ms โ”‚     
no change โ”‚
   > โ”‚ QQuery 18    โ”‚ 186.46 ms โ”‚                             173.42 ms โ”‚ 
+1.08x faster โ”‚
   > โ”‚ QQuery 19    โ”‚  24.07 ms โ”‚                              25.47 ms โ”‚  
1.06x slower โ”‚
   > โ”‚ QQuery 20    โ”‚  31.98 ms โ”‚                              33.17 ms โ”‚     
no change โ”‚
   > โ”‚ QQuery 21    โ”‚ 142.18 ms โ”‚                             151.87 ms โ”‚  
1.07x slower โ”‚
   > โ”‚ QQuery 22    โ”‚  14.83 ms โ”‚                              14.71 ms โ”‚     
no change โ”‚
   > 
โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   > โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   > โ”ƒ Benchmark Summary                                    โ”ƒ           โ”ƒ
   > โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   > โ”‚ Total Time (HEAD)                                    โ”‚ 1045.35ms โ”‚
   > โ”‚ Total Time (revive_to_use_upstream_arrow_coalesce)   โ”‚ 1060.21ms โ”‚
   > โ”‚ Average Time (HEAD)                                  โ”‚   47.52ms โ”‚
   > โ”‚ Average Time (revive_to_use_upstream_arrow_coalesce) โ”‚   48.19ms โ”‚
   > โ”‚ Queries Faster                                       โ”‚         2 โ”‚
   > โ”‚ Queries Slower                                       โ”‚        10 โ”‚
   > โ”‚ Queries with No Change                               โ”‚        10 โ”‚
   > โ”‚ Queries with Failure                                 โ”‚         0 โ”‚
   > โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   > ```
   
   cc @alamb @2010YOUY01  It seems still regression after addressing the 
comments. I need more investigation and try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to