findepi commented on code in PR #17189:
URL: https://github.com/apache/datafusion/pull/17189#discussion_r2277481985
##########
datafusion/expr/src/logical_plan/extension.rs:
##########
@@ -57,7 +57,7 @@ pub trait UserDefinedLogicalNode: fmt::Debug + Send + Sync {
fn schema(&self) -> &DFSchemaRef;
/// Perform check of invariants for the extension node.
- fn check_invariants(&self, check: InvariantLevel, plan: &LogicalPlan) ->
Result<()>;
+ fn check_invariants(&self, check: InvariantLevel) -> Result<()>;
Review Comment:
It definitely is. `Drop redundant param from
WindowFunctionDefinition::return_field` is also an API change.
Is there a way to fix UDLN's `check_invariants` gracefully? We can introduce
a new function that delegates to the old (synthesizing temporary `plan`), but
deprecation won't be visible to downstream projects until we remove the old
one. Which sounds like the breakage is still there.
Or should we just rename the `plan` argument to `_ignore` to avoid breaking
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
