alamb commented on code in PR #17199:
URL: https://github.com/apache/datafusion/pull/17199#discussion_r2279420009
##########
datafusion/expr/src/logical_plan/invariants.rs:
##########
@@ -74,7 +74,7 @@ pub fn assert_executable_invariants(plan: &LogicalPlan) ->
Result<()> {
fn assert_valid_extension_nodes(plan: &LogicalPlan, check: InvariantLevel) ->
Result<()> {
plan.apply_with_subqueries(|plan: &LogicalPlan| {
if let LogicalPlan::Extension(Extension { node }) = plan {
- node.check_invariants(check, plan)?;
Review Comment:
Oh, I see -- the point is there is no value to getting the plan passed in
here as there is nothing else in `LogicalPlan::Extension(Extension { node })`
That makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
