alamb commented on issue #17207: URL: https://github.com/apache/datafusion/issues/17207#issuecomment-3192293792
> As I was reading through this I was feeling somewhat concerned about how easy it might be to accidentally miss calls that should be instrumented, however, I think the implementation suggestion completely solves any of those concerns. Indeed -- since all IO is routed through the ObjectStore trait I think we can be pretty sure about not missing any of them > I do have one small concern here, which is the output may end up being very verbose, potentially to the point of being useless for human consumption in certain situations. An example situation might be something like a highly selective filter operating on string (binary) data for a large parquet dataset. Just the quantity of GET requests to fetch parquet pages could end up being overwhelming. I don't want to let "perfect" be the enemy of "good," so perhaps this is better suited to a follow-on PR, but I'm wondering if summary statistics might end up being generally more useful than individual request data. I agree that would be good Maybe we could have different formats for outputting the display * `text` - full details human readable * `summary` -- the summary format you propos * `json` -- machine readable output 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
