alamb commented on PR #17090: URL: https://github.com/apache/datafusion/pull/17090#issuecomment-3192672292
> Amazing work overall! A lot of the diff is updating debug outputs / slt tests. I think it will help a lot to split this up into multiple PRs so that e.g. that can be reviewed separately from a smaller diff with complex logic changes. I agree with @adriangb that splitting this into multiple PRs would make this much easier to thoroughly review From my past experience, handling pushdown for outerjoins in general is quite subtle (especially in the presence of nulls, etc) and I have chased down many very subtle bugs in my past lives. Testing (with nulls) is especially important too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
