comphead commented on code in PR #2163:
URL: https://github.com/apache/datafusion-comet/pull/2163#discussion_r2280502690
##########
native/core/src/execution/utils.rs:
##########
@@ -81,7 +81,7 @@ impl SparkArrowConvert for ArrayData {
Ok(ffi_array)
}
- /// Move this ArrowData to pointers of Arrow C data interface.
+ /// Transfer ownership of the Rust-allocated data to the FFI layer so that
Java can consume it.
Review Comment:
```suggestion
/// Moves ArrowData to Spark JVM side. Transfers ownership of the
Rust-allocated data to the FFI layer so that Java can consume it.
```
##########
native/core/src/execution/utils.rs:
##########
@@ -81,7 +81,7 @@ impl SparkArrowConvert for ArrayData {
Ok(ffi_array)
}
- /// Move this ArrowData to pointers of Arrow C data interface.
+ /// Transfer ownership of the Rust-allocated data to the FFI layer so that
Java can consume it.
Review Comment:
```suggestion
/// Moves ArrowData to Spark JVM side. Transfers ownership of the
Rust-allocated data to the FFI layer so that JVM can consume it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
