adamreeve commented on code in PR #17137:
URL: https://github.com/apache/datafusion/pull/17137#discussion_r2281027278
##########
.github/workflows/rust.yml:
##########
@@ -220,6 +220,8 @@ jobs:
run: cargo check --profile ci --no-default-features -p datafusion
--features=unicode_expressions
- name: Check parquet encryption (parquet_encryption)
run: cargo check --profile ci --no-default-features -p datafusion
--features=parquet_encryption
+ - name: Check parquet encryption (parquet, parquet_encryption)
+ run: cargo check --profile ci --no-default-features -p datafusion
--features=parquet,parquet_encryption
Review Comment:
This seems like it should be redundant but then I noticed that the
`parquet_encryption` feature doesn't actually depend on the `parquet` feature.
Maybe we should remove this extra check run as the one above already tests the
`parquet_encryption` feature, and update `datafusion/core/Cargo.toml` so that
the `parquet_encryption` feature depends on the `parquet` feature rather than
just `dep:parquet`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
