alamb commented on code in PR #17113:
URL: https://github.com/apache/datafusion/pull/17113#discussion_r2282718716
##########
datafusion/functions/src/math/round.rs:
##########
@@ -84,9 +79,41 @@ impl ScalarUDFImpl for RoundFunc {
&self.signature
}
+ fn coerce_types(&self, arg_types: &[DataType]) -> Result<Vec<DataType>> {
Review Comment:
why do we need a custom coerce types method? Why not just add two more
entries to the existing table of `one_of`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
