parthchandra commented on code in PR #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180#discussion_r2283621119
##########
native/core/src/execution/jni_api.rs:
##########
@@ -173,12 +175,22 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_createPlan(
let start = Instant::now();
+ // Deserialize query plan
let array = unsafe { JPrimitiveArray::from_raw(serialized_query) };
let bytes = env.convert_byte_array(array)?;
-
- // Deserialize query plan
let spark_plan = serde::deserialize_op(bytes.as_slice())?;
+ // Deserialize Spark configs
+ let array = unsafe {
JPrimitiveArray::from_raw(serialized_spark_configs) };
+ let bytes = env.convert_byte_array(array)?;
+ let spark_configs = serde::deserialize_config(bytes.as_slice())?;
+
+ // Convert Spark configs to HashMap
+ let _spark_config_map: HashMap<String, String> = spark_configs
Review Comment:
Oh, right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
