adriangb commented on code in PR #17234:
URL: https://github.com/apache/datafusion/pull/17234#discussion_r2284009395
##########
datafusion/physical-plan/src/analyze.rs:
##########
@@ -134,9 +134,8 @@ impl ExecutionPlan for AnalyzeExec {
vec![&self.input]
}
- /// AnalyzeExec is handled specially so this value is ignored
fn required_input_distribution(&self) -> Vec<Distribution> {
- vec![]
+ vec![Distribution::UnspecifiedDistribution]
Review Comment:
This seems rational to me. I'm guessing 1 item per children is expected?
Since we know we have 1 child it makes sense to abide by that. If it were a lot
more complex or something it'd be justifiable but it's actually less LOC to
just implement this right than to leave a comment explaining why it's not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
