andygrove commented on code in PR #2154: URL: https://github.com/apache/datafusion-comet/pull/2154#discussion_r2285426260
########## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ########## @@ -207,8 +203,7 @@ object QueryPlanSerde extends Logging with CometExprShim { supportedDataType(a.elementType, allowComplex) case m: MapType if allowComplex => supportedDataType(m.keyType, allowComplex) && supportedDataType(m.valueType, allowComplex) - case dt => - emitWarning(s"unsupported Spark data type: $dt") Review Comment: Callers of `supportedDataType` now call `withInfo` to record the fallback reason -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org