andygrove opened a new issue, #2192:
URL: https://github.com/apache/datafusion-comet/issues/2192
### What is the problem the feature request solves?
I often see logging such as:
```
Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark
partitioning: ArrayBuffer(nation#310 ASC NULLS FIRST, o_year#311 DESC NULLS
LAST)
```
However, this does not explain _why_ this partitioning is not supported. It
could be for multiple reasons:
```scala
val supported =
expressions.map(QueryPlanSerde.exprToProto(_,
inputs)).forall(_.isDefined) &&
expressions.forall(e =>
supportedHashPartitionKeyDataType(e.dataType)) &&
inputs.forall(attr => supportedShuffleDataType(attr.dataType)) &&
CometConf.COMET_EXEC_SHUFFLE_WITH_HASH_PARTITIONING_ENABLED.get(conf)
if (!supported) {
withInfo(s, s"unsupported Spark partitioning: $expressions")
}
```
It would be better to split this code up into multiple simple checks so that
we can report the actual reason
### Describe the potential solution
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
