alamb commented on issue #13563: URL: https://github.com/apache/datafusion/issues/13563#issuecomment-3201702314
> Since the SQL support is already in datafusion-sqlparser-rs, it looks like the main work is on the second part. Let me start exploring what is required to implement this as an extension and get back with any questions. Thank you @theirix What I would recommend we do is start working in an example in https://github.com/apache/datafusion/blob/main/datafusion-examples/examples as a way to explore what is possible today. I am happy to take an early look / provide some feedback/ help along the example I suspect we can do almost everything needed with existing APIs The high level steps might be: 1. Parse the relevant SQL into some sort of `Statement::Sample` 2. Use the LogicalPlanBuilder to create a plan for that new statement 3. Implement a custom extension node, if necessary, to implement the sampling Does that make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org