andygrove opened a new issue, #2198:
URL: https://github.com/apache/datafusion-comet/issues/2198
### Describe the bug
When I implemented `auto` scan mode, I overlooked the checks for encryption
being enabled.
We choose a specific scan in the following code, which does not check for
encryption, so will likely pick `native_iceberg_compat` in most cases:
```scala
// if scan is auto then pick the best available scan
if (scanImpl == SCAN_AUTO) {
scanImpl = selectScan(scanExec, r.partitionSchema)
}
```
Later on we fall back to Spark if encryption is enabled and then scan is not
`native_comet`.
```scala
val encryptionEnabled: Boolean =
conf.getConfString("parquet.crypto.factory.class", "").nonEmpty &&
conf.getConfString("parquet.encryption.kms.client.class",
"").nonEmpty
if (scanImpl != CometConf.SCAN_NATIVE_COMET && encryptionEnabled) {
fallbackReasons +=
"Full native scan disabled because encryption is not supported"
return withInfos(scanExec, fallbackReasons.toSet)
}
```
### Steps to reproduce
_No response_
### Expected behavior
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
