adriangb commented on PR #17245: URL: https://github.com/apache/datafusion/pull/17245#issuecomment-3202365682
> ๐ค: Benchmark completed > > Details > ``` > Comparing HEAD and alamb_no_arc_swap > -------------------- > Benchmark run_topk_tpch.json > -------------------- > โโโโโโโโโโโโโโโโณโโโโโโโโโโโโณโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโโโโโโ > โ Query โ HEAD โ alamb_no_arc_swap โ Change โ > โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ > โ Q1 โ 24.18 ms โ 7.58 ms โ +3.19x faster โ > โ Q2 โ 40.41 ms โ 30.69 ms โ +1.32x faster โ > โ Q3 โ 102.54 ms โ 98.51 ms โ no change โ > โ Q4 โ 34.07 ms โ 35.96 ms โ 1.06x slower โ > โ Q5 โ 24.11 ms โ 28.40 ms โ 1.18x slower โ > โ Q6 โ 44.68 ms โ 62.56 ms โ 1.40x slower โ > โ Q7 โ 118.34 ms โ 123.79 ms โ no change โ > โ Q8 โ 88.24 ms โ 72.87 ms โ +1.21x faster โ > โ Q9 โ 92.60 ms โ 107.90 ms โ 1.17x slower โ > โ Q10 โ 156.89 ms โ 161.26 ms โ no change โ > โ Q11 โ 77.43 ms โ 12.17 ms โ +6.36x faster โ > โโโโโโโโโโโโโโโโดโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโ > โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโณโโโโโโโโโโโ > โ Benchmark Summary โ โ > โกโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฉ > โ Total Time (HEAD) โ 803.48ms โ > โ Total Time (alamb_no_arc_swap) โ 741.69ms โ > โ Average Time (HEAD) โ 73.04ms โ > โ Average Time (alamb_no_arc_swap) โ 67.43ms โ > โ Queries Faster โ 4 โ > โ Queries Slower โ 4 โ > โ Queries with No Change โ 3 โ > โ Queries with Failure โ 0 โ > โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโ > ``` @alamb I think it's pretty clear most of the performance improvement is not coming from ArcSwap. The [other benches](https://github.com/apache/datafusion/pull/16433#issuecomment-3201715769) are a *bit* better, but not much. It's going to be hard to measure. And you've clearly made improvements in this PR. So I'm going to merge it into mine, we can always revisit the ArcSwap later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
