andygrove commented on code in PR #2194:
URL: https://github.com/apache/datafusion-comet/pull/2194#discussion_r2288278378
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -851,30 +874,40 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
}
val inputs = s.child.output
+ if (!checkSupportedShuffleDataTypes(s)) {
+ return false
+ }
+
val partitioning = s.outputPartitioning
partitioning match {
case HashPartitioning(expressions, _) =>
- // columnar shuffle supports the same data types (including complex
types) both for
- // partition keys and for other columns
- val supported =
- expressions.map(QueryPlanSerde.exprToProto(_,
inputs)).forall(_.isDefined) &&
- expressions.forall(e => supportedShuffleDataType(e.dataType)) &&
Review Comment:
The check `expressions.forall(e => supportedShuffleDataType(e.dataType))`
should not have been here - we just need to check that we support the data type
of the inputs, not the partitioning expressions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
