wiedld commented on code in PR #17249: URL: https://github.com/apache/datafusion/pull/17249#discussion_r2291880052
########## datafusion/common/src/dfschema.rs: ########## @@ -297,6 +297,19 @@ impl DFSchema { /// Modify this schema by appending the fields from the supplied schema, ignoring any /// duplicate fields. + /// + /// ## Merge Precedence + /// + /// **Schema-level metadata**: Metadata from both schemas is merged. + /// If both schemas have the same metadata key, the value from the second `other_schema` parameter takes precedence. + /// + /// **Field-level merging**: Only non-duplicate fields are added. This means that the + /// first `self` fields will always take precedence over the second `other_schema` fields. Review Comment: Wording changes are good. Thank you. Added: https://github.com/apache/datafusion/pull/17249/commits/25c798abdac5c08186d895d0517e4865688d5401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org