alamb commented on code in PR #17275: URL: https://github.com/apache/datafusion/pull/17275#discussion_r2291917756
########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -1314,7 +1314,7 @@ physical_plan 11)┌─────────────┴─────────────┐┌─────────────┴─────────────┐ 12)│ DataSourceExec ││ DataSourceExec │ 13)│ -------------------- ││ -------------------- │ -14)│ bytes: 6040 ││ bytes: 6040 │ +14)│ bytes: 5932 ││ bytes: 5932 │ Review Comment: I believe the in memory size may have improved due to - https://github.com/apache/arrow-rs/pull/7984 And the Vec doesn't have the same minimum alignment / size that the builders had ########## datafusion/physical-plan/src/spill/mod.rs: ########## @@ -724,7 +724,7 @@ mod tests { .unwrap(); let size = get_record_batch_memory_size(&batch); - assert_eq!(size, 8320); + assert_eq!(size, 8208); Review Comment: - Also due to https://github.com/apache/arrow-rs/pull/7984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
