Jefffrey commented on code in PR #17255: URL: https://github.com/apache/datafusion/pull/17255#discussion_r2295094117
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -7387,3 +7389,58 @@ FROM (VALUES ('a'), ('d'), ('c'), ('a')) t(a_varchar); query error Error during planning: ORDER BY and WITHIN GROUP clauses cannot be used together in the same aggregate function SELECT array_agg(a_varchar order by a_varchar) WITHIN GROUP (ORDER BY a_varchar) FROM (VALUES ('a'), ('d'), ('c'), ('a')) t(a_varchar); + +# distinct average +statement ok +create table distinct_avg (a int, b int) as values + (null, null), + (1, 1), + (2, 2), + (3, 3), + (4, 4), Review Comment: Will work on adding these cases 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org