sgrebnov commented on code in PR #17306:
URL: https://github.com/apache/datafusion/pull/17306#discussion_r2296343450
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -401,25 +401,35 @@ fn get_valid_types(
let mut fixed_size = array_coercion !=
Some(&ListCoercion::FixedSizedListToList);
let mut list_sizes = Vec::with_capacity(arguments.len());
let mut element_types = Vec::with_capacity(arguments.len());
+ let mut nested_item_nullability = Vec::with_capacity(arguments.len());
for (argument, current_type) in
arguments.iter().zip(current_types.iter()) {
match argument {
Review Comment:
Alternative approach that could be considered is the following, pls let me
know if you prefer this one (does not require `nested_item_nullability`
handling separately in each match)
```rust
for (argument, current_type) in arguments.iter().zip(current_types.iter()) {
let mut field_nullability = None;
match argument {
...
DataType::LargeList(field) => {
...
field_nullability = Some(field.is_nullable());
}
...
}
nested_item_nullability.push(field_nullability);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
