adamreeve commented on code in PR #16738:
URL: https://github.com/apache/datafusion/pull/16738#discussion_r2296900790
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -1654,7 +1636,8 @@ async fn output_single_parquet_file_parallelized(
object_store_writer: Box<dyn AsyncWrite + Send + Unpin>,
data: Receiver<RecordBatch>,
output_schema: Arc<Schema>,
- parquet_props: &WriterProperties,
+ writer_properties: &WriterProperties,
+ skip_arrow_metadata: bool,
Review Comment:
I don't follow why this new `skip_arrow_metadata` parameter is needed. It
looks like this wasn't used previously so is this a change in behaviour where
previously this option was ignored?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
