kosiew commented on code in PR #17021:
URL: https://github.com/apache/datafusion/pull/17021#discussion_r2297004893
##########
datafusion-cli/tests/cli_integration.rs:
##########
@@ -352,10 +401,34 @@ fn test_backtrace_output(#[case] query: &str) {
let stderr = String::from_utf8_lossy(&output.stderr);
let combined_output = format!("{}{}", stdout, stderr);
- // Assert that the output includes literal 'backtrace'
+ // Accept either a printed backtrace or a readable error message.
+ // Some builds may not include backtrace support in the binary; in that
+ // case the CLI prints a clear planning error message instead. Verify one
+ // of these is present to avoid a fragile test.
+ let has_backtrace = combined_output.to_lowercase().contains("backtrace");
+ let lower_stdout = stdout.to_lowercase();
+ let lower_stderr = stderr.to_lowercase();
+
+ let has_planning_error = lower_stdout.contains("failed to coerce
arguments")
Review Comment:
<img width="1512" height="400" alt="image"
src="https://github.com/user-attachments/assets/71776aa2-97dc-474b-97f3-7fde8b56fcba";
/>
🤦 This seemed to be from tests related to another branch related to
cast_column for struct support.
I am very sorry that I did not notice the unrelated change creeping into
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
