friendlymatthew commented on PR #17076: URL: https://github.com/apache/datafusion/pull/17076#issuecomment-3220741860
> Thanks @adriangb, @blaginin, @friendlymatthew IMO crashing on not setting `batch_size` is super confusing indeed. However as long as the error is pretty descriptive and the API allows to overcome this issue by calling `with_batch_size` we should be fine. Totally agree the bigger refactoring is needed and having some default value for `batch_size` and making the file open routine less troublesome. > > For this PR I'm pretty sure it would add a migration pain for downstream users having a limited benefit. > > @friendlymatthew would you like to start a refactoring? Hi, here's the proposed refactor: https://github.com/apache/datafusion/pull/17242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
