andygrove commented on code in PR #1975:
URL: https://github.com/apache/datafusion-comet/pull/1975#discussion_r2299015436
##########
common/src/main/scala/org/apache/spark/sql/comet/util/Utils.scala:
##########
@@ -124,7 +125,10 @@ object Utils {
case LongType => new ArrowType.Int(8 * 8, true)
case FloatType => new
ArrowType.FloatingPoint(FloatingPointPrecision.SINGLE)
case DoubleType => new
ArrowType.FloatingPoint(FloatingPointPrecision.DOUBLE)
- case StringType => ArrowType.Utf8.INSTANCE
+ case _: StringType => ArrowType.Utf8.INSTANCE
+ case dt if isStringCollationType(dt) =>
+ // TODO collation information is lost with this transformation
Review Comment:
I removed this comment because Spark also does not track this information,
as pointed out in
https://github.com/apache/datafusion-comet/issues/2190#issuecomment-3215876465
by @parthchandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
