etolbakov commented on code in PR #17216:
URL: https://github.com/apache/datafusion/pull/17216#discussion_r2300170004
##########
datafusion/pruning/src/pruning_predicate.rs:
##########
@@ -1369,7 +1368,7 @@ impl PredicateRewriter {
let mut required_columns = RequiredColumns::new();
build_predicate_expression(
expr,
- schema,
+ &Arc::new(schema.clone()),
Review Comment:
@adriangb Thanks for the approval & merge!
That made my first contribution to the Datafusion project 🎉!
I have found only one instance of the
`rewrite_predicate_to_statistics_predicate` invocation (technically, there are
2) in the `test_rewrite_expr_to_prunable_custom_unhandled_hook`.
I'm happy to adjust `rewrite_predicate_to_statistics_predicate` signature to
accept `&SchemaRef` as per your suggestion.
Please let me know if you'd like me to do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
