comphead commented on code in PR #2242:
URL: https://github.com/apache/datafusion-comet/pull/2242#discussion_r2305580436
##########
spark/src/main/scala/org/apache/comet/expressions/CometCast.scala:
##########
@@ -136,7 +187,7 @@ object CometCast {
// https://github.com/apache/datafusion-comet/issues/328
Incompatible(Some("Not all valid formats are supported"))
case _ =>
- Unsupported
+ Unsupported(Some(s"Cast from String to $toType is not supported"))
Review Comment:
can see lots of Unsupported(Some(s"Cast from String to $toType is not
supported")), canthis be a helper function?
```
def unsupportedCast(from, to) {
Unsupported(Some(s"Cast from $from to $to is not supported"))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
