BlakeOrth commented on code in PR #17266:
URL: https://github.com/apache/datafusion/pull/17266#discussion_r2308250575
##########
datafusion-cli/src/print_options.rs:
##########
@@ -73,6 +77,8 @@ pub struct PrintOptions {
pub quiet: bool,
pub maxrows: MaxRows,
pub color: bool,
+ pub object_store_profile_mode: InstrumentedObjectStoreMode,
+ pub instrumented_registry: Arc<InstrumentedObjectStoreRegistry>,
Review Comment:
I don't love carrying this as a public member of this struct, but I didn't
want to go making too many unnecessary changes without some additional reviewer
input. I feel like `PrintOptions` might be to the point where it needs a
builder or perhaps a dedicated `new()` method to better encapsulate its
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
