findepi opened a new pull request, #17393: URL: https://github.com/apache/datafusion/pull/17393
Before the changes, `PartialOrd` could return `Some(Equal)` for two `Window` nodes that are not equal in `PartialEq` sense. This is violation of `PartialOrd` contract. The fix is to consult eq inside ord implementation. If ord thinks two instances are equal, but they are not equal in Eq sense, they are considered incomparable. - follows https://github.com/apache/datafusion/pull/17182 - for https://github.com/apache/datafusion/issues/17064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
