crepererum commented on issue #6880: URL: https://github.com/apache/datafusion/issues/6880#issuecomment-3252463528
> the "merge" button may be available, but if the target branch was updated in the meantime, CI may then fail This "may" happen, but TBH I've rarely seen this. On the positive side as a maintainer I can just hit the queue button and walk away without having to worry about semantic/test conflicts (i.e. the ones not detected by GIT) on the target branch. That's also why the merge queue is rather efficient by default because it can test multiple entries of the queue, assuming that the previous entries will pass CI. If that assumption fails, entries will be retested with the failed entry removed. What I am wondering though: what happens to commits in PR that are added/pushed AFTER the PR was added to the queue? IIRC that removes the PR from the queue (as one might expect, because we don't want people to sneak in changes) but I cannot find any first-party sources for that behavior. > Also, do we have any flaky tests? How will flakiness interact with merge queue? I'm not aware of any and I think we should be rather strict with them if they come up. Flaky tests just act like normal test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
