comphead commented on code in PR #17391:
URL: https://github.com/apache/datafusion/pull/17391#discussion_r2322960477
##########
datafusion/expr/src/udaf.rs:
##########
@@ -991,6 +779,259 @@ impl PartialOrd for dyn AggregateUDFImpl {
}
}
+pub fn udaf_default_schema_name<F: AggregateUDFImpl + ?Sized>(
+ func: &F,
+ params: &AggregateFunctionParams,
+) -> Result<String> {
+ let AggregateFunctionParams {
+ args,
+ distinct,
+ filter,
+ order_by,
+ null_treatment,
+ } = params;
+
+ // exclude the first function argument(= column) in ordered set aggregate
function,
+ // because it is duplicated with the WITHIN GROUP clause in schema name.
+ let args = if func.is_ordered_set_aggregate() {
+ &args[1..]
+ } else {
+ &args[..]
+ };
+
+ let mut schema_name = String::new();
+
+ schema_name.write_fmt(format_args!(
+ "{}({}{})",
+ func.name(),
+ if *distinct { "DISTINCT " } else { "" },
+ schema_name_from_exprs_comma_separated_without_space(args)?
+ ))?;
+
+ if let Some(null_treatment) = null_treatment {
+ schema_name.write_fmt(format_args!(" {null_treatment}"))?;
+ }
+
+ if let Some(filter) = filter {
+ schema_name.write_fmt(format_args!(" FILTER (WHERE {filter})"))?;
+ };
+
+ if !order_by.is_empty() {
+ let clause = match func.is_ordered_set_aggregate() {
+ true => "WITHIN GROUP",
+ false => "ORDER BY",
+ };
+
+ schema_name.write_fmt(format_args!(
+ " {} [{}]",
+ clause,
+ schema_name_from_sorts(order_by)?
+ ))?;
+ };
+
+ Ok(schema_name)
+}
+
+pub fn udaf_default_human_display<F: AggregateUDFImpl + ?Sized>(
+ func: &F,
+ params: &AggregateFunctionParams,
+) -> Result<String> {
+ let AggregateFunctionParams {
+ args,
+ distinct,
+ filter,
+ order_by,
+ null_treatment,
+ } = params;
+
+ let mut schema_name = String::new();
+
+ schema_name.write_fmt(format_args!(
+ "{}({}{})",
+ func.name(),
+ if *distinct { "DISTINCT " } else { "" },
+ ExprListDisplay::comma_separated(args.as_slice())
+ ))?;
+
+ if let Some(null_treatment) = null_treatment {
+ schema_name.write_fmt(format_args!(" {null_treatment}"))?;
+ }
+
+ if let Some(filter) = filter {
+ schema_name.write_fmt(format_args!(" FILTER (WHERE {filter})"))?;
+ };
+
+ if !order_by.is_empty() {
+ schema_name.write_fmt(format_args!(
+ " ORDER BY [{}]",
+ schema_name_from_sorts(order_by)?
+ ))?;
+ };
+
+ Ok(schema_name)
+}
+
+pub fn udaf_default_window_function_schema_name<F: AggregateUDFImpl + ?Sized>(
Review Comment:
if it is for external uses it would be good to have the method documented IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
