andygrove commented on code in PR #2299:
URL: https://github.com/apache/datafusion-comet/pull/2299#discussion_r2322245615
##########
spark/src/test/scala/org/apache/comet/objectstore/NativeConfigSuite.scala:
##########
@@ -119,15 +119,18 @@ class NativeConfigSuite extends AnyFunSuite with Matchers
with BeforeAndAfterEac
test("validity cache") {
val hadoopConf = new Configuration()
- hadoopConf.set("fs.s3a.endpoint", "https://acme.storage.com";)
Review Comment:
This used to trigger a validate error but that changed in
https://github.com/apache/datafusion-comet/pull/2288
##########
spark/src/test/scala/org/apache/comet/objectstore/NativeConfigSuite.scala:
##########
@@ -119,15 +119,18 @@ class NativeConfigSuite extends AnyFunSuite with Matchers
with BeforeAndAfterEac
test("validity cache") {
val hadoopConf = new Configuration()
- hadoopConf.set("fs.s3a.endpoint", "https://acme.storage.com";)
Review Comment:
This used to trigger a validation error, but that changed in
https://github.com/apache/datafusion-comet/pull/2288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
