findepi opened a new pull request, #17442: URL: https://github.com/apache/datafusion/pull/17442
When eq is derived, it unnecessarily invokes eq on the `set` field. It's more expensive that simple `Vec` eq done on the `expr` field. Fortunately it's redundant, the `set` field is logically derived from `expr`. This also updates `PartialOrd` implementation to emphasize the fact that `PartialEq` and `PartialOrd` need to be consistent. They already were consistent, it's a stylistic change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
