adriangb commented on code in PR #17336:
URL: https://github.com/apache/datafusion/pull/17336#discussion_r2324613129


##########
datafusion/catalog/src/table.rs:
##########
@@ -171,6 +171,41 @@ pub trait TableProvider: Debug + Sync + Send {
         limit: Option<usize>,
     ) -> Result<Arc<dyn ExecutionPlan>>;
 
+    /// Create an [`ExecutionPlan`] for scanning the table using structured 
arguments.
+    ///
+    /// This method uses [`ScanArgs`] to pass scan parameters in a structured 
way
+    /// and returns a [`ScanResult`] containing the execution plan. This 
approach
+    /// allows for extensible parameter passing and result handling.
+    ///
+    /// Table providers can override this method to take advantage of 
additional
+    /// parameters like `preferred_ordering` that may not be available through

Review Comment:
   Sorry outdated docstring. But the point is that we can add arguments and 
return values without it being a breaking change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to