comphead opened a new issue, #2382:
URL: https://github.com/apache/datafusion-comet/issues/2382

   ### What is the problem the feature request solves?
   
   Currently `BaseAggregateExec` doesn't support some scenarios, like grouping 
on maps or filtering. 
   
   ```
   if (aggregateExpressions.exists(_.filter.isDefined)) {
             withInfo(op, "Aggregate expression with filter is not supported")
             return None
           }
   
           if (groupingExpressions.exists(expr =>
               expr.dataType match {
                 case _: MapType => true
                 case _ => false
               })) {
             withInfo(op, "Grouping on map types is not supported")
             return None
           }
   
           val groupingExprs = groupingExpressions.map(exprToProto(_, 
child.output))
           if (groupingExprs.exists(_.isEmpty)) {
             withInfo(op, "Not all grouping expressions are supported")
             return None
           }
   ```
   - [ ] Support map types for aggregation
   - [ ] Support agg expr with filter
   
   ### Describe the potential solution
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to