andygrove commented on code in PR #2385:
URL: https://github.com/apache/datafusion-comet/pull/2385#discussion_r2342701643


##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -68,15 +68,14 @@ object CometLower extends 
CometCaseConversionBase[Lower]("lower")
 
 object CometInitCap extends CometScalarFunction[InitCap]("initcap") {
 
+  override def getSupportLevel(expr: InitCap): SupportLevel = {

Review Comment:
   Yes:
   
   ```
   !== Correct Answer - 7 ==       == Spark Answer - 7 ==
    struct<initcap(name):string>   struct<initcap(name):string>
    [James Smith]                  [James Smith]
    [James Smith]                  [James Smith]
    [James Ähtäri]                 [James Ähtäri]
    [Michael Rose]                 [Michael Rose]
    [Rames Rose]                   [Rames Rose]
   ![Robert Rose-smith]            [Robert Rose-Smith]
    [Robert Williams]              [Robert Williams]
    ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to