Jefffrey commented on code in PR #17531: URL: https://github.com/apache/datafusion/pull/17531#discussion_r2342909798
########## datafusion/expr-common/src/signature.rs: ########## @@ -43,6 +43,13 @@ pub const TIMEZONE_WILDCARD: &str = "+TZ"; /// valid length. It exists to avoid the need to enumerate all possible fixed size list lengths. pub const FIXED_SIZE_LIST_WILDCARD: i32 = i32::MIN; +/// Constant that is used as a placeholder for any valid fixed size binary. +/// This is used where a function can accept a fixed size binary type with any +/// valid length. It exists to avoid the need to enumerate all possible fixed size binary lengths. +/// +/// The value is offset by 1 to make it distinct from [`FIXED_SIZE_LIST_WILDCARD`]. +pub const FIXED_SIZE_BINARY_WILDCARD: i32 = i32::MIN + 1; Review Comment: Just in case someone puts `FIXED_SIZE_LIST_WILDCARD` when they meant `FIXED_SIZE_BINARY_WILDCARD`, as otherwise they would be interchangeable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
