mbutrovich commented on code in PR #2286:
URL: https://github.com/apache/datafusion-comet/pull/2286#discussion_r2353173529
##########
native/spark-expr/src/predicate_funcs/rlike.rs:
##########
@@ -47,19 +46,18 @@ pub struct RLike {
pattern: Regex,
}
-impl Hash for RLike {
- fn hash<H: Hasher>(&self, state: &mut H) {
- state.write(self.pattern_str.as_bytes());
+impl PartialEq for RLike {
+ fn eq(&self, other: &Self) -> bool {
+ self.pattern_str == other.pattern_str
Review Comment:
`PartialEq` only looks at the `pattern_str` and not the child. I think I'd
have to clone the `Arc` to do the comparison, and I'm not sure that's the
behavior we want. However, the hasher hashes the child. What do we think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
