alan910127 commented on issue #17612: URL: https://github.com/apache/datafusion/issues/17612#issuecomment-3308288469
`sqllogictest` supports [`<slt:ignore>`](https://github.com/risinglightdb/sqllogictest-rs#extension-ignore-volatile-parts-of-output) in the default validator to skip parts of a line, but that doesn’t cover this scenario. Maybe we could add something like `<slt:contain>` in our custom validators ([`sqlite_value_validator`](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/bin/sqllogictests.rs#L64) and [`df_value_validator`](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/src/util.rs#L80)): ```sql # Test that IS NOT DISTINCT FROM join produces HashJoin when used alone query TT EXPLAIN SELECT t1.id AS t1_id, t2.id AS t2_id, t1.val, t2.val FROM t1 JOIN t2 ON t1.val IS NOT DISTINCT FROM t2.val ---- <slt:contain>HashJoinExec ``` Not sure if this is a good solution though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
