Jefffrey commented on code in PR #17667:
URL: https://github.com/apache/datafusion/pull/17667#discussion_r2362812812
##########
datafusion/functions-nested/src/extract.rs:
##########
@@ -776,15 +768,7 @@ pub(super) struct ArrayPopBack {
impl ArrayPopBack {
pub fn new() -> Self {
Self {
- signature: Signature {
- type_signature: TypeSignature::ArraySignature(
- ArrayFunctionSignature::Array {
- arguments: vec![ArrayFunctionArgument::Array],
- array_coercion:
Some(ListCoercion::FixedSizedListToList),
- },
- ),
- volatility: Volatility::Immutable,
- },
+ signature: Signature::array(Volatility::Immutable),
Review Comment:
Ditto
##########
datafusion/functions-nested/src/extract.rs:
##########
@@ -672,15 +672,7 @@ pub(super) struct ArrayPopFront {
impl ArrayPopFront {
pub fn new() -> Self {
Self {
- signature: Signature {
- type_signature: TypeSignature::ArraySignature(
- ArrayFunctionSignature::Array {
- arguments: vec![ArrayFunctionArgument::Array],
- array_coercion:
Some(ListCoercion::FixedSizedListToList),
- },
- ),
- volatility: Volatility::Immutable,
- },
+ signature: Signature::array(Volatility::Immutable),
Review Comment:
Not related to array_slice, just refactoring to make use of equivalent
`Signature::array` function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
