milenkovicm commented on code in PR #17650:
URL: https://github.com/apache/datafusion/pull/17650#discussion_r2363396518
##########
datafusion/expr/src/registry.rs:
##########
@@ -27,9 +27,25 @@ use std::sync::Arc;
/// A registry knows how to build logical expressions out of user-defined
function' names
pub trait FunctionRegistry {
- /// Set of all available udfs.
+ /// Returns names of all available scalar user defined functions.
fn udfs(&self) -> HashSet<String>;
+ /// Returns names of all available aggregate user defined functions.
+ fn udafs(&self) -> HashSet<String> {
+ // This default implementation is provided temporarily
Review Comment:
A bit confused by your comment @alamb not sure how is this functionality
related to ud(a|w)?f serialisation.
If we want to demonstrate ud(a|w)?f serialisation maybe something like
https://github.com/milenkovicm/ballista_python/blob/0398011f2b200dd44dd91e3da5de89e863a45c71/src/codec.rs#L197-L220
could be done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
